Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Data Sources for Service Quotas #9122

Closed
bflad opened this issue Jun 25, 2019 · 4 comments · Fixed by #9177
Closed

Support Data Sources for Service Quotas #9122

bflad opened this issue Jun 25, 2019 · 4 comments · Fixed by #9177
Assignees
Labels
new-data-source Introduces a new data source. service/servicequotas Issues and PRs that pertain to the servicequotas service.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Jun 25, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The new Service Quotas service provides lookups for existing service quotas. Let's support those lookups via new data source(s).

For managing service quotas, see #9118

New Data Source

  • aws_servicequotas_service
  • aws_servicequotas_service_quota

Potential Terraform Configuration

# Relevant API Calls:
#   ListServicesPages
# Additional attributes:
#   service_code # TypeString, Computed
data "aws_servicequotas_service" "example" {
  service_name  = "..." # TypeString, Required
}

# Relevant API Calls:
#   GetServiceQuota
#   ListServiceQuotasPages
# Additional attributes:
#   value # TypeFloat, Computed
data "aws_servicequotas_service_quota" "example" {
  quota_code    = "..." # TypeString, Optional, ConflictsWith quota_name
  quota_name    = "..." # TypeString, Optional, ConflictsWith quota_code
  service_code  = "..." # TypeString, Required
}

References

@bflad bflad added new-data-source Introduces a new data source. service/servicequotas Issues and PRs that pertain to the servicequotas service. labels Jun 25, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 25, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jun 25, 2019
bflad added a commit that referenced this issue Jun 28, 2019
Reference: #9122

Output from acceptance testing:

```
--- PASS: TestAccAwsServiceQuotasServiceDataSource_ServiceName (15.13s)
```
bflad added a commit that referenced this issue Jun 28, 2019
Reference: #9122

Output from acceptance testing:

```
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaCode (9.93s)
--- PASS: TestAccAwsServiceQuotasServiceQuotaDataSource_QuotaName (10.11s)
```
@bflad
Copy link
Contributor Author

bflad commented Jun 28, 2019

Pull request submitted: #9177

@bflad bflad self-assigned this Jun 28, 2019
@bflad bflad added this to the v2.18.0 milestone Jul 1, 2019
@bflad
Copy link
Contributor Author

bflad commented Jul 1, 2019

The following has been merged and will release with version 2.18.0 of the Terraform AWS Provider, likely later this week. 👍

  • New Data Source: aws_servicequotas_service
  • New Data Source: aws_servicequotas_service_quota

@bflad
Copy link
Contributor Author

bflad commented Jul 5, 2019

This has been released in version 2.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-data-source Introduces a new data source. service/servicequotas Issues and PRs that pertain to the servicequotas service.
Projects
None yet
1 participant