resource/aws_rds_cluster: Properly update master_password during snapshot restore #9505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shot restore Reference: #9492 Since we cannot read the master password from the API during `Read`, it would silently be saved with the configuration value in the Terraform state and never trigger an update. This cannot be found via the acceptance testing framework without attempting to connect to the RDS Cluster (e.g. via the mysql provider), but relatedly added a test for master_username since that was also missing during snapshot restore, which highlighted a related missing test. ``` --- FAIL: TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername (377.68s) testing.go:568: Step 0 error: Check failed: Check 4/4 error: aws_rds_cluster.test: Attribute 'master_username' expected "username1", got "foo" --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword (378.00s) ``` Output from acceptance testing: ``` --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword (364.62s) --- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername (387.26s) ```
bflad
added
bug
ghost
added
size/M
ryndaniels
approved these changes
Jul 25, 2019
|
This has been released in version 2.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests, documentation updates, or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #9492
Release note for CHANGELOG:
Since we cannot read the master password from the API during
Read, it would silently be saved with the configuration value in the Terraform state and never trigger an update. This cannot be found via the acceptance testing framework without attempting to connect to the RDS Cluster (e.g. via the mysql provider), but relatedly added a test for master_username since that was also missing during snapshot restore, which highlighted a related missing test.Output from acceptance testing: