Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand data.aws_workspaces_bundle With Owner/Name Filtering #12497

Merged
merged 3 commits into from
Jun 18, 2020
Merged

Expand data.aws_workspaces_bundle With Owner/Name Filtering #12497

merged 3 commits into from
Jun 18, 2020

Conversation

Tensho
Copy link
Contributor

@Tensho Tensho commented Mar 21, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12496

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsWorkspaceBundle'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWorkspaceBundle -timeout 120m
=== RUN   TestAccDataSourceAwsWorkspaceBundle_basic
=== PAUSE TestAccDataSourceAwsWorkspaceBundle_basic
=== RUN   TestAccDataSourceAwsWorkspaceBundle_byOwnerName
=== PAUSE TestAccDataSourceAwsWorkspaceBundle_byOwnerName
=== RUN   TestAccDataSourceAwsWorkspaceBundle_bundleIDAndNameConflict
=== PAUSE TestAccDataSourceAwsWorkspaceBundle_bundleIDAndNameConflict
=== CONT  TestAccDataSourceAwsWorkspaceBundle_basic
=== CONT  TestAccDataSourceAwsWorkspaceBundle_bundleIDAndNameConflict
=== CONT  TestAccDataSourceAwsWorkspaceBundle_byOwnerName
--- PASS: TestAccDataSourceAwsWorkspaceBundle_bundleIDAndNameConflict (3.01s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_basic (21.38s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_byOwnerName (23.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.821s

@Tensho Tensho requested a review from a team March 21, 2020 19:16
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 21, 2020
@Tensho Tensho force-pushed the d-workspaces-bundle-filter branch 2 times, most recently from 5d45969 to a188809 Compare March 21, 2020 19:21
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Mar 21, 2020
@Tensho Tensho force-pushed the d-workspaces-bundle-filter branch from a188809 to 5759822 Compare May 28, 2020 08:03
@Tensho
Copy link
Contributor Author

Tensho commented May 28, 2020

@bflad @gdavison @ewbankkit Could we merge this?

@Tensho Tensho mentioned this pull request Jun 3, 2020
Closed
@gdavison gdavison self-assigned this Jun 3, 2020
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Jun 4, 2020
gdavison
gdavison requested changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple things to rephrase

website/docs/d/workspaces_bundle.html.markdown Outdated Show resolved Hide resolved
aws/data_source_aws_workspaces_bundle_test.go Show resolved Hide resolved
aws/data_source_aws_workspaces_bundle.go Outdated Show resolved Hide resolved
aws/data_source_aws_workspaces_bundle.go Outdated Show resolved Hide resolved
aws/data_source_aws_workspaces_bundle.go Outdated Show resolved Hide resolved
@Tensho Tensho force-pushed the d-workspaces-bundle-filter branch from 5759822 to b2d49c9 Compare June 5, 2020 08:55
@Tensho
Copy link
Contributor Author

Tensho commented Jun 5, 2020

@gdavison Added fixes according to your review 🚀

gdavison
gdavison approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccDataSourceAwsWorkspaceBundle_bundleIDAndNameConflict (1.40s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_basic (9.22s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_byOwnerName (9.68s)

@gdavison gdavison merged commit 99e4caa into hashicorp:master Jun 18, 2020
@gdavison gdavison added this to the v2.67.0 milestone Jun 18, 2020
gdavison added a commit that referenced this pull request Jun 18, 2020
@gdavison
Update CHANGELOG for #12497
02cf864
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@Tensho Tensho deleted the d-workspaces-bundle-filter branch June 19, 2020 15:08
@ghost
Copy link

ghost commented Jul 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
documentation Introduces or discusses updates to documentation. service/workspaces Issues and PRs that pertain to the workspaces service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.67.0
Development

Successfully merging this pull request may close these issues.

Expand functionality of data.aws_workspaces_bundle to do local filtering
2 participants
@Tensho @gdavison