Application Gateway: Refactoring #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
approved these changes
Oct 26, 2018
tombuildsstuff
force-pushed
the
r/application-gateway
branch
3 times, most recently
from
74a2a0e to
36482c6
Compare
tombuildsstuff
force-pushed
the
r/application-gateway
branch
from
36482c6 to
255f3b2
Compare
This was referenced Nov 9, 2018
tombuildsstuff
force-pushed
the
r/application-gateway
branch
4 times, most recently
from
f2bcc00 to
77912b0
Compare
tombuildsstuff
force-pushed
the
r/application-gateway
branch
from
77912b0 to
3f93705
Compare
tombuildsstuff
force-pushed
the
r/application-gateway
branch
2 times, most recently
from
dff023a to
80400a9
Compare
tombuildsstuff
force-pushed
the
r/application-gateway
branch
from
80400a9 to
f1efeeb
Compare
|
Tests pass:
|
tombuildsstuff
added a commit
that referenced
this pull request
Nov 12, 2018
ghost
mentioned this pull request
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR normalizes the state of the
azurerm_application_gatewayresource to ensure that it can be iterated on in the future. Rather than making larger structural changes - this PR gets the resource to a known state (for example, ensuring that Lists are set as Lists rather than Sets, and rewriting the documentation) - and adds TODO's for future enhancements which are intentionally not implemented in this PR, for example:Given this is a large-scale refactor - to make this easier to review I've tried to keep one commit per 'thing' - so there's a large number of small commits (which I'm hoping makes this simpler to review but ¯_(ツ)_/¯)
Fixes #1907
Fixes #2155