-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource(s)/Data Sources for HDInsights Cluster #3196
Conversation
19e5484
to
a4a4936
Compare
``` === RUN TestHDInsightClusterVersionDiffSuppress === RUN TestHDInsightClusterVersionDiffSuppress/empty_name === RUN TestHDInsightClusterVersionDiffSuppress/missing_user_input === RUN TestHDInsightClusterVersionDiffSuppress/missing_api_response === RUN TestHDInsightClusterVersionDiffSuppress/major_minor_user_input === RUN TestHDInsightClusterVersionDiffSuppress/full_version_user_input --- PASS: TestHDInsightClusterVersionDiffSuppress (0.00s) --- PASS: TestHDInsightClusterVersionDiffSuppress/empty_name (0.00s) --- PASS: TestHDInsightClusterVersionDiffSuppress/missing_user_input (0.00s) --- PASS: TestHDInsightClusterVersionDiffSuppress/missing_api_response (0.00s) --- PASS: TestHDInsightClusterVersionDiffSuppress/major_minor_user_input (0.00s) --- PASS: TestHDInsightClusterVersionDiffSuppress/full_version_user_input (0.00s) PASS ```
``` === RUN TestHDInsightClusterVersion === RUN TestHDInsightClusterVersion/empty_name === RUN TestHDInsightClusterVersion/major_only === RUN TestHDInsightClusterVersion/major_minor === RUN TestHDInsightClusterVersion/major_minor_large === RUN TestHDInsightClusterVersion/major_minor_build === RUN TestHDInsightClusterVersion/major_minor_build_revision === RUN TestHDInsightClusterVersion/real-world-example --- PASS: TestHDInsightClusterVersion (0.00s) --- PASS: TestHDInsightClusterVersion/empty_name (0.00s) --- PASS: TestHDInsightClusterVersion/major_only (0.00s) --- PASS: TestHDInsightClusterVersion/major_minor (0.00s) --- PASS: TestHDInsightClusterVersion/major_minor_large (0.00s) --- PASS: TestHDInsightClusterVersion/major_minor_build (0.00s) --- PASS: TestHDInsightClusterVersion/major_minor_build_revision (0.00s) --- PASS: TestHDInsightClusterVersion/real-world-example (0.00s) PASS ```
28fe95f
to
63304cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from a couple minor comments LGTM @tombuildsstuff 👍
08d9a59
to
455dc3d
Compare
hi, Thanks |
This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.25.0"
}
# ... other configuration ... |
|
||
* `username` - The username used for the Ambari Portal. | ||
|
||
* `username` - The password used for the Ambari Portal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be password
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@widgetpl - yes - would you mind opening a new issue for this? thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tombuildsstuff done #3287 but should we make docs per cluster type like azurerm_hdinsight_kafka_cluster
, azurerm_hdinsight_hadoop_cluster
, azurerm_hdinsight_spark_cluster
I see there are some small differences?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I mixed data
with resource
documentation, everything is in place ;)
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR adds support for HDInsights, in all of its various incarnations - in particular this PR adds the following:
azurerm_hdinsight_cluster
azurerm_hdinsight_kafka_cluster
azurerm_hdinsight_kbase_cluster
azurerm_hdinsight_hadoop_cluster
azurerm_hdinsight_interactive_query_cluster
azurerm_hdinsight_ml_services_cluster
azurerm_hdinsight_rserver_cluster
azurerm_hdinsight_spark_cluster
azurerm_hdinsight_storm_cluster
The Data Source
azurerm_hdinsight_cluster
intentionally only exports a subset of fields since there's sufficient differences between the different kinds of HDInsights Cluster that this is both practical and (what I believe) are the relevant fields that most users are likely to need.Due to the HDInsights API being very pedantic about the result structure - rather than try and ship a single HDInsights Resource (as has been previously attempted in #1267, #924 and #814) this PR introduces separate resources for each "kind" of HDInsights Cluster, due to the number of these the resources in this PR follow a very different structure to other resources.
Remaining Tasks
ValidationDocumentation for the Nodepassword
fieldFixes #37