azurerm_api_management_api: correct validation to allow empty and strings 400 characters long

[simongh]

The api management api resource has a required property for path. This property can be left blank, according to the Azure docs (& how we're using it). The validation expression however requires it to be at least 3 characters long.

I've adjusted the regex to allow an empty path and to also enforce the maximum length as specified in Azure API spec (https://github.com/Azure/azure-rest-api-specs/blob/8578473fb7799590c01a7ce243a53121ababdb76/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2019-01-01/definitions.json#L129).

[katbyte]

Thanks for the correction @simongh, howerver it looks like you have a test failure:

--- FAIL: TestAzureRMApiManagementApiPath_validation (0.00s)
    api_management_test.go:134: Expected the Api Management Api Path to trigger a validation error for ''

[simongh]

I'm not sure what failed there. I think the linter doesn't like my change. I don't really use Go, so I'm not sure what I need to fix.

[katbyte]

@simongh,

go has a rather strict formatting guide that we enforce on all our PRs. the linting is failing because the code is not " formatted correctly. This can easily be fixed by running make fmt.

I hope you don't mind but i've done this for you 🙂

Provided CI now passes this LGTM 🚀

[simongh]

@katbyte that great, thanks

[ghost]

This has been released in version 1.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.29.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!