Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_key_vault_certificate #408

Merged
merged 6 commits into from
Oct 10, 2017

Conversation

tombuildsstuff
Copy link
Contributor

  • Support for Importing and Generating Key Vault Certificates
  • Updating the Key Vault SKU to be a List rather than a Set
  • Refactoring all the Key Vault child resources to use the same url parser given it's the same

The documentation for Key Vault Certificates is pretty non-existant, so I'm unable to determine which fields can be updated - as such I've made everything ForceNew for the moment and will implement Update in a future update.

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screen shot 2017-10-10 at 12 11 23

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit e549ec4 into master Oct 10, 2017
@tombuildsstuff tombuildsstuff deleted the key-vault-certificates branch October 10, 2017 16:08
tombuildsstuff added a commit that referenced this pull request Oct 10, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants