-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add App Service Environment resource and Data Source #5508
Conversation
8cd03d3
to
583ef27
Compare
We'll clean up the remaining files once #5508 has been merged
18541a3
to
abae97c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments inline (which I've pushed some commits to fix, as discussed) but this mostly LGTM 👍
azurerm/internal/services/web/tests/app_service_environment_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/web/validate/app_service_environment.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments inline (which I've pushed some commits to fix, as discussed) but this mostly LGTM 👍
eaee0f2
to
986f9c3
Compare
…rt only) Replaces #4956 Co-authored-by: @justinbarias
4ba5b15
to
26000c1
Compare
1a4c5af
to
f9f006e
Compare
Awesome job. Thanks for adding this. |
This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.0.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Adds new resource and datasource for App Service Environment (v2 support only)
Replaces #4956
Co-authored-by: @justinbarias
Fixes #438