-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Data Source: 'azurerm_eventhub_consumer_group' #5518
New Data Source: 'azurerm_eventhub_consumer_group' #5518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this pr @Brunhil! overall LGTM aside from a few minor comments ive left inline
azurerm/internal/services/eventhub/data_source_eventhub_consumer_group.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @Brunhil
Thanks for pushing those changes - apologies this has sat waiting for a re-review.
Taking a look through this LGTM - I'll kick off the tests now 👍
Thanks!
f004f7f
to
5aaf923
Compare
@Brunhil hope you don't mind but I've pushed the rebase for this |
dismissing since changes have been pushed
This has been released in version 1.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.44.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Add new data source 'azurerm_eventhub_consumer_group'
=== RUN TestAccDataSourceAzureRMEventHubConsumerGroup_complete
=== PAUSE TestAccDataSourceAzureRMEventHubConsumerGroup_complete
=== CONT TestAccDataSourceAzureRMEventHubConsumerGroup_complete
--- PASS: TestAccDataSourceAzureRMEventHubConsumerGroup_complete (202.86s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventhub/tests
203.125s