Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_dns_txt_record - support records up to 1024 characters in length #5837

Merged
merged 1 commit into from
Feb 29, 2020

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Feb 21, 2020

fixa #5547

According to dns txt record doc, a record length can be up to 1024 characters. To align with azure.cli and powershell, I set each record set length to 254 characters

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @njuCZ! LGTM 👍

@katbyte katbyte changed the title add support for long text record azurerm_dns_txt_record - support records up to 1024 characters in length Feb 29, 2020
@katbyte katbyte added this to the v2.1.0 milestone Feb 29, 2020
@katbyte katbyte merged commit c345a64 into hashicorp:master Feb 29, 2020
katbyte added a commit that referenced this pull request Feb 29, 2020
@bootc
Copy link

bootc commented Mar 3, 2020

I think this also fixes #2826

@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants