Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_frontdoor: Upcoming RP change forces all new front door resources to be created in the Global location #6015

Merged
merged 4 commits into from
Mar 10, 2020

Conversation

WodansSon
Copy link
Collaborator

No description provided.

@WodansSon WodansSon added documentation upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR service/frontdoor labels Mar 6, 2020
@WodansSon WodansSon added this to the v2.1.0 milestone Mar 6, 2020
@WodansSon WodansSon requested a review from katbyte March 6, 2020 03:25
@ghost ghost added the size/XL label Mar 6, 2020
@WodansSon
Copy link
Collaborator Author

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple comments on wording LGTM 👍


if hasLocation && preExists {
if location != azure.NormalizeLocation(cfgLocation) {
return fmt.Errorf("the Front Door %q (Resource Group %q) already exists in %q and cannot be moved to the %q location", name, resourceGroup, location, cfgLocation)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we state that the location is "x" and by placing that back in config it'll work?

@WodansSon
Copy link
Collaborator Author

image

@WodansSon WodansSon merged commit 324bc6d into master Mar 10, 2020
@WodansSon WodansSon deleted the b_frontdoor_global branch March 10, 2020 02:19
WodansSon added a commit that referenced this pull request Mar 10, 2020
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change documentation service/frontdoor size/XL upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants