-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource: azurerm_hpc_cache_blob_target #6035
new resource: azurerm_hpc_cache_blob_target #6035
Conversation
748d5d1
to
b006306
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @magodo
Thanks for this PR - apologies for the delayed review here!
Taking a look through here rather than casting to/from the Data Plane Resource ID we can instead use the Resource Manager ID for the Storage Container directly, which I've added in #6170. As such whilst this mostly looks good, I hope you don't mind but so that we can get this merged I'm going to push a commit to rebase this & fix up the pending comments now that #6170 has been merged.
Thanks!
azurerm/internal/services/storage/resource_arm_hpc_cache_blob_target.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/tests/resource_arm_hpc_cache_blob_target_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/resource_arm_hpc_cache_blob_target.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/resource_arm_hpc_cache_blob_target.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/resource_arm_hpc_cache_blob_target.go
Outdated
Show resolved
Hide resolved
b006306
to
af8ca85
Compare
af8ca85
to
c198101
Compare
c198101
to
cf1b5d0
Compare
This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.3.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This partially address #6014. Once it is merged, I'll go on implementing
azurerm_hpc_cache_nfs_target
.