Fix for ExpressRoute: No support for route filters for Microsoft peering #1083

[pearcec]

Added azurerm_route_filter resource. Updated azurerm_express_route_circuit_peering to include route_filter_id. Updated all the documentation. Tests included. Please review. I did set the test for the circuit to lowercase to match the existing tests. But I did run the TestAccAzureRMExpressRouteCircuitPeering_microsoftPeeringWithRouteFilter and it was successful.

make acctests SERVICE='network' TESTARGS='-run=TestAccAzureRMExpressRouteCircuitPeering' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
TF_ACC=1 go test -v ./azurerm/internal/services/network/tests/ -run=TestAccAzureRMExpressRouteCircuitPeering -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.Provider
Version=acc"
=== RUN   TestAccAzureRMExpressRouteCircuitPeering_microsoftPeeringWithRouteFilter
--- PASS: TestAccAzureRMExpressRouteCircuitPeering_microsoftPeeringWithRouteFilter (372.94s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/tests       375.315s

Fixes: #1083

[pearcec]

I added a commit how do I get it to retest or update the pull?

[pearcec]

@tombuildsstuff Reviewing another expressroute issue, I see why we set test to lower case now in resource_arm_express_route_circuit_test.go func TestAccAzureRMExpressRouteCircuit(t *testing.T) { combines them all.

This needs reworked. Feel free to flag it as such. I will work on it today.

[manicminer]

Thanks for this @pearcec, it looks great. I rebased onto master and tests are passing.

[ghost]

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

[azrael-lu]

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

It is great to have azurerm_route_filter, finally, I could replace the azurerm_template_deployment for route filter in my TF template.
But I still can not find the document update for azurerm_route_filter.
Could you please let me know when we will have the document for resource"azurerm_route_filter"?

Thanks.

[manicminer]

Hi @azrael-lu, the resource doc is published here (data source doc here)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!