app_service_environment: add field resource_group_name
#6821
Conversation
There was a problem hiding this comment.
Hi @magodo
Thanks for this PR.
Just a couple of really minor changes below. I'll run the acceptance tests today in readiness for merge.
Ste
| @@ -35,6 +35,16 @@ func SchemaResourceGroupNameForDataSource() *schema.Schema { | |||
| } | |||
| } | |||
|
|
|||
| func SchemaResourceGroupNameOC() *schema.Schema { | |||
There was a problem hiding this comment.
Can we have this as SchemaResourceGroupNameOptionalComputed so it's clearer purpose?
azurerm/internal/services/web/app_service_environment_resource.go
Outdated
Show resolved
Hide resolved
|
@jackofallops Thank you for your comment! |
|
Tests pass (2 failures unrelated to PR / transient) |
|
This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.10.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
This PR allows user to explicitly specify the resource group for app_service_environment, instead of implicitly using the one from Subnet.
In order to keep compatibility, the newly added
resource_group_nameis set asOptional+Computed, which should be changed toRequiredwhen a major version of provider bumps.Fix /#6699.