upgrade network to 2020-05-01 for vhub(conn) & vwan #7601

magodo · 2020-07-07T02:10:17Z

Upgrade network to 2020-05-01 for virtual hub(conn) & virtual wan resources.

Changes include:

Use the dedicated client for azurerm_virtualhub_connection, as the original field in azurerm_virtualhub used to create/delete vhub conn is removed from API.
Deprecate hub_to_vitual_network_traffic_allowed and vitual_network_to_hub_gateways_traffic_allowed from azurerm_virtualhub_connection, as they are deprecated by API.
Deprecate allow_vnet_to_vnet_traffic from azurerm_virtual_wan as this is not deprecated by API.

(follow-up PR for #7585 )
(fixes #7896 )

tombuildsstuff

left a few comments inline but this otherwise LGTM 👍

azurerm/internal/services/network/virtual_hub_connection_resource.go

tombuildsstuff · 2020-07-07T09:57:44Z

website/docs/r/virtual_hub_connection.html.markdown


-* `vitual_network_to_hub_gateways_traffic_allowed` - (Optional) Is Remote Virtual Network traffic allowed to transit the Hub's Virtual Network Gateway's? Changing this forces a new resource to be created.
+* `vitual_network_to_hub_gateways_traffic_allowed` - (Optional / **Deprecated** ) Is Remote Virtual Network traffic allowed to transit the Hub's Virtual Network Gateway's? Changing this forces a new resource to be created.


arguably since this is non-functional we could remove this:

Suggested change

* `vitual_network_to_hub_gateways_traffic_allowed` - (Optional / **Deprecated** ) Is Remote Virtual Network traffic allowed to transit the Hub's Virtual Network Gateway's? Changing this forces a new resource to be created.

How about just keep this (as user is still allowed to assign it) but change the document so something like:

Due to a breaking behavioural change in the Azure API this property is no longer functional and will be removed in version 3.0 of the provider

tombuildsstuff · 2020-07-07T09:57:46Z

website/docs/r/virtual_hub_connection.html.markdown

@@ -58,9 +58,9 @@ The following arguments are supported:

 ---

-* `hub_to_vitual_network_traffic_allowed` - (Optional) Is the Virtual Hub traffic allowed to transit via the Remote Virtual Network? Changing this forces a new resource to be created.
+* `hub_to_vitual_network_traffic_allowed` - (Optional / **Deprecated** ) Is the Virtual Hub traffic allowed to transit via the Remote Virtual Network? Changing this forces a new resource to be created.


arguably since this is non-functional we could remove this:

Suggested change

* `hub_to_vitual_network_traffic_allowed` - (Optional / **Deprecated** ) Is the Virtual Hub traffic allowed to transit via the Remote Virtual Network? Changing this forces a new resource to be created.

tombuildsstuff · 2020-07-07T09:58:05Z

website/docs/r/virtual_wan.html.markdown

@@ -40,7 +40,7 @@ The following arguments are supported:

 * `allow_branch_to_branch_traffic` - (Optional) Boolean flag to specify whether branch to branch traffic is allowed. Defaults to `true`.

-* `allow_vnet_to_vnet_traffic` - (Optional) Boolean flag to specify whether VNet to VNet traffic is allowed. Defaults to `false`.
+* `allow_vnet_to_vnet_traffic` - (Optional / **Deprecated** ) Boolean flag to specify whether VNet to VNet traffic is allowed. Defaults to `false`.


arguably since this is non-functional we could remove this:

Suggested change

* `allow_vnet_to_vnet_traffic` - (Optional / **Deprecated** ) Boolean flag to specify whether VNet to VNet traffic is allowed. Defaults to `false`.

azurerm/internal/services/network/tests/virtual_hub_connection_resource_test.go

magodo · 2020-07-08T02:08:04Z

@tombuildsstuff Thank you for the review comments! I have updated accordingly. Please take a look!
I have no idea why the CI failed, as I only made some minor changes. I also tried the make depscheck locally with no problem...

WodansSon

@magodo, thanks so much for this PR, LGTM! 🚀

magodo · 2020-08-10T07:27:46Z

@WodansSon I have submit another update to ensure the routing state reaches "Provisioned" so as to avoid race condition between vhub internal routing update and hub vnet connection caused routing update.

I have tested it in West Europe:

💤 make testacc TEST=./azurerm/internal/services/network/tests TESTARGS='-run TestAccAzureRMVirtualHubConnection_update'

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/network/tests -v -run TestAccAzureRMVirtualHubConnection_update -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMVirtualHubConnection_update
=== PAUSE TestAccAzureRMVirtualHubConnection_update
=== CONT  TestAccAzureRMVirtualHubConnection_update
--- PASS: TestAccAzureRMVirtualHubConnection_update (3117.31s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/tests       3117.349s

WodansSon

@magodo, thank you for pushing these changes, this LGTM 🚀

tombuildsstuff

hey @magodo

Thanks for pushing those changes - I've taken a look through and left some comments inline; if we can fix those up then this should otherwise be good to merge (we'll need to add an "upgrade note" to the changelog, but we'll do that at merge time)

Thanks!

azurerm/internal/services/network/virtual_hub_connection_resource.go

azurerm/internal/services/network/virtual_hub_resource.go

azurerm/internal/services/network/virtual_hub_connection_resource.go

azurerm/internal/services/network/client/client.go

magodo · 2020-08-26T13:23:00Z

@tombuildsstuff I have resolved the remaining comments, please take another look! Thanks!

…_security_enabled` The deprecated attributes are always `true` on return, as they are deprecated, we can simply suppress any diff on it. `internet_security_enabled` seems has changed in this new version that it is `false` even if it is omit in the request.

…_network_resources_to_2020-05-01

…etwork_resources_to_2020-05-01

magodo · 2020-09-22T04:11:41Z

@tombuildsstuff I have resolved the remaining comments, especially this one. Would you please take another look?

…_network_resources_to_2020-05-01

WodansSon · 2020-09-22T06:47:46Z

@magodo, thanks for pushing these changes and fixing the conflict! 🚀

WodansSon · 2020-09-22T23:50:27Z

Dilergore · 2020-09-24T07:34:06Z

Hi,

This is very urgent. Using the old API version will clear the routes on the vWAN causing major issues. We had a production incident caused by this.

Also mentioned as recommended in the vWAN FAQ:
https://docs.microsoft.com/en-us/azure/virtual-wan/virtual-wan-faq#what-is-the-recommended-api-version-to-be-used-by-scripts-automating-various-virtual-wan-functionalities

tombuildsstuff

LGTM 👍

ghost · 2020-09-24T18:47:20Z

This has been released in version 2.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.29.0"
}
# ... other configuration ...

ghost · 2020-10-24T14:50:18Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

ghost added size/XL documentation size/XXL dependencies and removed size/XL labels Jul 7, 2020

neil-yechenwei mentioned this pull request Jul 7, 2020

Manage Virtual Hub Connection with new HubVirtualNetworkConnection API #7388

Closed

tombuildsstuff suggested changes Jul 7, 2020

View reviewed changes

magodo added 3 commits July 20, 2020 11:44

upgrade network to 2020-05-01 for vhub(conn) & vwan

49730a8

modify per review

37b61fd

go mod tidy && go mod vendor

58c0ee0

magodo force-pushed the upgrade_remaining_network_resources_to_2020-05-01 branch from 3b522f1 to 58c0ee0 Compare July 20, 2020 03:47

naioja mentioned this pull request Jul 27, 2020

Old Azure vWAN API issues. New vWAN Routing features are not enabled #7896

Closed

WodansSon approved these changes Aug 5, 2020

View reviewed changes

WodansSon added this to the v2.22.0 milestone Aug 5, 2020

WodansSon added service/virtual-wan service/virtual-hub labels Aug 5, 2020

WodansSon modified the milestones: v2.22.0, Blocked Aug 6, 2020

vhub creation wait for routing provision

2c9b17f

WodansSon approved these changes Aug 11, 2020

View reviewed changes

WodansSon modified the milestones: Blocked, v2.24.0 Aug 18, 2020

tombuildsstuff self-assigned this Aug 19, 2020

tombuildsstuff modified the milestones: v2.24.0, v2.25.0 Aug 20, 2020

tombuildsstuff suggested changes Aug 25, 2020

View reviewed changes

tombuildsstuff added the waiting-response label Aug 25, 2020

resolve review comment (except introducing IDFormtter)

3216575

tombuildsstuff assigned magodo and unassigned tombuildsstuff Aug 26, 2020

resolve review comment

78d8b7f

tombuildsstuff modified the milestones: v2.25.0, v2.26.0 Aug 27, 2020

Merge remote-tracking branch 'upstream/master' into upgrade_remaining…

da4f941

…_network_resources_to_2020-05-01

tombuildsstuff modified the milestones: v2.26.0, v2.27.0 Sep 3, 2020

jackofallops modified the milestones: v2.27.0, v2.28.0 Sep 10, 2020

WodansSon modified the milestones: v2.28.0, v2.29.0 Sep 16, 2020

katbyte and others added 2 commits September 21, 2020 15:41

Merge remote-tracking branch 'origin/master' into upgrade_remaining_n…

473be4f

…etwork_resources_to_2020-05-01

explicitly set the deprecated proerpties to false

2b24616

magodo added 3 commits September 22, 2020 13:05

Merge remote-tracking branch 'upstream/master' into upgrade_remaining…

fea38ae

…_network_resources_to_2020-05-01

Merge remote-tracking branch 'upstream/master' into upgrade_remaining…

81fc6f7

…_network_resources_to_2020-05-01

go fmt

25a9c4a

tombuildsstuff self-requested a review September 22, 2020 16:29

tombuildsstuff approved these changes Sep 24, 2020

View reviewed changes

tombuildsstuff merged commit 3515a71 into hashicorp:master Sep 24, 2020

tombuildsstuff added a commit that referenced this pull request Sep 24, 2020

updating to include #7601

a0b12cf

ghost locked as resolved and limited conversation to collaborators Oct 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade network to 2020-05-01 for vhub(conn) & vwan #7601

upgrade network to 2020-05-01 for vhub(conn) & vwan #7601

magodo commented Jul 7, 2020 •

edited by WodansSon

Loading

tombuildsstuff left a comment

tombuildsstuff Jul 7, 2020

magodo Jul 8, 2020

tombuildsstuff Jul 7, 2020

tombuildsstuff Jul 7, 2020

magodo commented Jul 8, 2020 •

edited

Loading

WodansSon left a comment

magodo commented Aug 10, 2020 •

edited

Loading

WodansSon left a comment

tombuildsstuff left a comment

magodo commented Aug 26, 2020

magodo commented Sep 22, 2020

WodansSon commented Sep 22, 2020

WodansSon commented Sep 22, 2020

Dilergore commented Sep 24, 2020 •

edited

Loading

tombuildsstuff left a comment

ghost commented Sep 24, 2020

ghost commented Oct 24, 2020


		* `vitual_network_to_hub_gateways_traffic_allowed` - (Optional) Is Remote Virtual Network traffic allowed to transit the Hub's Virtual Network Gateway's? Changing this forces a new resource to be created.
		* `vitual_network_to_hub_gateways_traffic_allowed` - (Optional / Deprecated ) Is Remote Virtual Network traffic allowed to transit the Hub's Virtual Network Gateway's? Changing this forces a new resource to be created.

upgrade network to 2020-05-01 for vhub(conn) & vwan #7601

upgrade network to 2020-05-01 for vhub(conn) & vwan #7601

Conversation

magodo commented Jul 7, 2020 • edited by WodansSon Loading

tombuildsstuff left a comment

Choose a reason for hiding this comment

tombuildsstuff Jul 7, 2020

Choose a reason for hiding this comment

magodo Jul 8, 2020

Choose a reason for hiding this comment

tombuildsstuff Jul 7, 2020

Choose a reason for hiding this comment

tombuildsstuff Jul 7, 2020

Choose a reason for hiding this comment

magodo commented Jul 8, 2020 • edited Loading

WodansSon left a comment

Choose a reason for hiding this comment

magodo commented Aug 10, 2020 • edited Loading

WodansSon left a comment

Choose a reason for hiding this comment

tombuildsstuff left a comment

Choose a reason for hiding this comment

magodo commented Aug 26, 2020

magodo commented Sep 22, 2020

WodansSon commented Sep 22, 2020

WodansSon commented Sep 22, 2020

Dilergore commented Sep 24, 2020 • edited Loading

tombuildsstuff left a comment

Choose a reason for hiding this comment

ghost commented Sep 24, 2020

ghost commented Oct 24, 2020

magodo commented Jul 7, 2020 •

edited by WodansSon

Loading

magodo commented Jul 8, 2020 •

edited

Loading

magodo commented Aug 10, 2020 •

edited

Loading

Dilergore commented Sep 24, 2020 •

edited

Loading