-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move HDInsight tests to 4.0 and mark 3.6 only resources deprecated #7706
Move HDInsight tests to 4.0 and mark 3.6 only resources deprecated #7706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @kosinsky
Thanks for this PR :)
Taking a look through this looks good - if we can update the terminology used in the deprecation messages then this otherwise LGTM 👍
Thanks!
azurerm/internal/services/hdinsight/hdinsight_ml_services_cluster_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/hdinsight/hdinsight_rserver_cluster_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/hdinsight/hdinsight_storm_cluster_resource.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing those changes @kosinsky
Tests look good 👍 - the failing tests have been reported to the service team in this upstream issue |
This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.19.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Implements 2.x parts for #7670
Note ml_services an rserver tests are very flaky and fail with
HDI Version'3.6' is not supported for clusterType 'MLServices' and componentVersion 'default'.
most of the timeTests for other 6 resource types are green.