Make update of allow_extensions_operations independent from provision_vm_agent.

[NilsBusche]

This fixes the bug reported in #7985.

There is no API restriction which does not allow enabling
allow_extensions_operations if provision_vm_agent is false.
For example you can install the agent manually and after that enable
allow_extensions_operations.

Fixes #7985

[mbfrahry]

Hey @NilsBusche, this is just about there but we should keep the check in the create method since we can't create a virtual machine when allow_extensions_operations is true but provision_vm_agent is false.

Original Error: Code="InvalidParameter" Message="The value of parameter allowExtensionOperations is invalid."

Removing it from update makes sense to me!

[NilsBusche]

Hey @NilsBusche, this is just about there but we should keep the check in the create method since we can't create a virtual machine when allow_extensions_operations is true but provision_vm_agent is false.

Original Error: Code="InvalidParameter" Message="The value of parameter allowExtensionOperations is invalid."

Removing it from update makes sense to me!

Hi @mbfrahry, you are correct. I changed this.

[tombuildsstuff]

hey @NilsBusche

Thanks for pushing those changes - taking a look through this mostly LGTM - however can we add a test case to confirm that updating this field works (for both the Linux & Windows VM resources)?

Thanks!

[NilsBusche]

hey @NilsBusche

Thanks for pushing those changes - taking a look through this mostly LGTM - however can we add a test case to confirm that updating this field works (for both the Linux & Windows VM resources)?

Thanks!

Hi @tombuildsstuff, I think there is already a test for checking if update works:
https://github.com/terraform-providers/terraform-provider-azurerm/blob/8442c30c2d443dcf90cfadbd8b52c4fba16d3189/azurerm/internal/services/compute/tests/linux_virtual_machine_resource_other_test.go#L52

Should we add/change a test to make sure that updating allow_extension_operations also works if provision_vm_agent was set to false at creation of the virtual machine? Or do you think the existing tests are sufficient?

[mbfrahry]

Should we add/change a test to make sure that updating allow_extension_operations also works if provision_vm_agent was set to false at creation of the virtual machine? Or do you think the existing tests are sufficient?

Let's add those tests for sure just to make sure that it's doing what we expect it to do

[NilsBusche]

Let's add those tests for sure just to make sure that it's doing what we expect it to do

Hi @mbfrahry, added tests for updating allow_extension_operations if provision_vm_agent is false.

[tombuildsstuff]

LGTM - thanks for pushing those changes @NilsBusche

dismissing since changes have been pushed

[ghost]

This has been released in version 2.26.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.26.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!