support managed identity for "azurerm_spring_cloud_app" #8336
Conversation
njuCZ
commented
Sep 3, 2020
njuCZ
commented
There was a problem hiding this comment.
hi @njuCZ
Thanks for this PR.
I've taken a look through and left some comments inline but if we can fix those up and the tests pass then this otherwise LGTM 👍
Thanks!
azurerm/internal/services/appplatform/spring_cloud_app_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/appplatform/spring_cloud_app_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/appplatform/spring_cloud_app_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/appplatform/spring_cloud_app_resource.go
Outdated
Show resolved
Hide resolved
|
@tombuildsstuff I have modifed this PR according to the suggestions. Could you please have a look again? |
|
Tests pass:
|
|
This has been released in version 2.27.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.27.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
