Add os_disk_type to kubernetes_cluster_node_pool

[favoretti]

Fixes #8657

[tombuildsstuff]

hey @favoretti

Thanks for this PR :)

Taking a look through this is looking good - if we can fix up the other minor comments then this otherwise LGTM 👍

Thanks!

[favoretti]

Running acceptance tests locally now.

[favoretti]

$ TF_ACC=1 go test -v ./azurerm/internal/services/containers/tests/ -timeout=1000m -run TestAccAzureRMKubernetesClusterNodePool_osDiskType
=== RUN   TestAccAzureRMKubernetesClusterNodePool_osDiskType
=== PAUSE TestAccAzureRMKubernetesClusterNodePool_osDiskType
=== CONT  TestAccAzureRMKubernetesClusterNodePool_osDiskType
--- PASS: TestAccAzureRMKubernetesClusterNodePool_osDiskType (951.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers/tests	952.503s

[NillsF]

@favoretti : Thank you for submitting this PR.
@tombuildsstuff: Will this get merged prior to Nov 19 to ensure it gets included in the next release?

[tombuildsstuff]

LGTM - thanks for pushing those changes @favoretti

[tombuildsstuff]

Tests look good 👍

[ghost]

This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.37.0"
}
# ... other configuration ...

[djsly]

FYI, this forces a rebuild for old cluster, unless users reimports / hack their state file with oDiskType: Managed

[favoretti]

How come? I haven’t seen this effect on 10+ clusters I have. Can you share a snippet of your cluster + pool definition? Thanks!

…

On Thu, 26 Nov 2020 at 22:39, Sylvain Boily ***@***.***> wrote: FYI, this forces a rebuild for old cluster, unless users reimports / hack their state file with oDiskType: Managed — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9166 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGERNRSDI74QJ6Y42HL4PDSR3DHHANCNFSM4TLJVPXA> .

[djsly]

had this on our tfplan:
+ os_disk_type = "Managed" # forces replacement
After modifying the state file and adding "os_disk_type": "Managed", it no longer detects any change

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!