new resource azurerm_iothub_enrichment and support azurerm_iothub.enrichment

[royto]

resolves #5872

[katbyte]

Thanks for this pr @royto, overall this looks pretty good. However may i ask why you are allowing enrichments to be added both on the iot hub directly and separately with a new resoruce?

[katbyte]

And validate these?

[royto]

I do the same as it is done for route endpoints

[katbyte]

Could we add a final basic step here?

[royto]

What do you mean by a final basic step ? Is some checks missing ?

To be honest, it is my first PR on terraform (and first time with Go). I took inspiration from what has been done on the test from iothub_route_resource_test.go

[royto]

However may i ask why you are allowing enrichments to be added both on the iot hub directly and separately with a new resoruce?

This is what is done for others (routes, fallback routes, endpoints (EH, SB Topic, .., ...)

So I thought it is needed to be the same for enrichment.

For example, In my need I will create the enrichment using the dedicated resource. But for other case, it is simpler to use the iothub resource. IMHO, Both makes sense.

[royto]

@katbyte is it Ok for you ?

[katbyte]

Thanks @royto - this LGTM 👍

[katbyte]

@royto - once the merge conflicts are fixed up this is good to mege!

[royto]

@katbyte rebase done. Conflicts fixed and Code updated to match new standard

[maxbog]

@katbyte Any chance of including it in the next release? Would be great if we could use it in my team.

[ghost]

This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.45.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!