Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new data source azurerm_servicebus_subscription #9272

Merged
merged 9 commits into from
Nov 19, 2020
Merged

added new data source azurerm_servicebus_subscription #9272

merged 9 commits into from
Nov 19, 2020

Conversation

ritesh-modi
Copy link
Contributor

@ritesh-modi ritesh-modi commented Nov 11, 2020 •
edited by tombuildsstuff
Loading

Added a new Data source azurerm_servicebus_subscription
added test files and modified the website documentation.

riteshmodi@MININT-57VL578 terraform-provider-azurerm % make build
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
go generate ./azurerm/internal/provider/
go install
riteshmodi@MININT-57VL578 terraform-provider-azurerm % make acctests SERVICE='servicebus' TESTARGS='-run=TestAccDataSourceAzureRMServiceBusSubscription' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/servicebus/tests/ -run=TestAccDataSourceAzureRMServiceBusSubscription -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceAzureRMServiceBusSubscription_basic
=== PAUSE TestAccDataSourceAzureRMServiceBusSubscription_basic
=== CONT  TestAccDataSourceAzureRMServiceBusSubscription_basic
--- PASS: TestAccDataSourceAzureRMServiceBusSubscription_basic (307.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/servicebus/tests	(cached)

Fixes #9278

@ritesh-modi ritesh-modi mentioned this pull request Nov 16, 2020
Closed
tombuildsstuff
tombuildsstuff suggested changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ritesh-modi

Thanks for this PR - apologies for the delayed review here!

Taking a look through this mostly LGTM - if we can update the wording in the documentation (since this is a Data Source, these fields are read-only - and thus the language wants to be slightly different to the Resource) - then we should be able to run the tests and get this merged 👍

Thanks!

azurerm/internal/services/servicebus/tests/data_source_servicebus_subscription_test.go Outdated
return fmt.Sprintf(testAccDataSourceAzureRMServiceBusSubscription_tfTemplate, data.RandomInteger, data.Locations.Primary, data.RandomInteger, data.RandomInteger, data.RandomInteger, "")
}

const testAccDataSourceAzureRMServiceBusSubscription_tfTemplate = `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(which means we could remove this constant)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed !

tombuildsstuff
tombuildsstuff approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ritesh-modi

I've taken a look through and ignoring two minor comments that I missed last time (sorry, I'll push a fix for those) - this otherwise LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff added this to the v2.37.0 milestone Nov 19, 2020
@tombuildsstuff
Copy link
Contributor

Tests pass

Screenshot 2020-11-19 at 16 10 14

@tombuildsstuff tombuildsstuff merged commit bcfde28 into hashicorp:master Nov 19, 2020
tombuildsstuff added a commit that referenced this pull request Nov 19, 2020
@tombuildsstuff
updating to include #9272
6d26eb5
@ghost
Copy link

ghost commented Nov 20, 2020

This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation new-data-source service/service-bus size/L
Projects
None yet
Milestone
v2.37.0
Development

Successfully merging this pull request may close these issues.

Data source for Azure Servicebus Subscription
2 participants
@ritesh-modi @tombuildsstuff