Skip to content
This repository has been archived by the owner on Dec 5, 2020. It is now read-only.

SSL Support #11

Merged
merged 3 commits into from
Feb 22, 2018
Merged

SSL Support #11

merged 3 commits into from
Feb 22, 2018

Conversation

jtopjian
Copy link
Contributor

This commit adds options to help with SSL connectivity:

  • insecure: ignore SSL warnings and errors. useful for self-signed certs.
  • cacert_file: specify the path or contents of a ca certificate.

This commit adds options to help with SSL connectivity:

* insecure: ignore SSL warnings and errors. useful for self-signed certs.
* cacert_file: specify the path or contents of a ca certificate.
Copy link

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor 🤔 - otherwise LGTM 👍

"cacert_file": &schema.Schema{
Type: schema.TypeString,
Optional: true,
DefaultFunc: envDefaultFunc("COBBLER_CACERT"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be COBBLER_CACERT_FILE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'll get this fixed right now.

@jtopjian
Copy link
Contributor Author

@tombuildsstuff Updated + added docs for the new settings.

Copy link

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jtopjian jtopjian merged commit dc88e73 into hashicorp:master Feb 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants