Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read named ports changes properly in google_compute_instance_group #188

Merged
merged 1 commit into from
Jul 13, 2017

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Jul 12, 2017

Fixed #170

Set the named ports when reading the current state of an instance group.
Removed the call to the read method in the update method before performing the actual update, this overrides the changes to the named ports field with my fix.
In order to handle the case where referenced instances have been removed earlier in the run, instead of doing the pre-read, don't fail if the InstanceGroups#RemoveInstances method returns a 404 (Not Found). If the instances have already been removed, this is the state we want to be in anyway.
Fixed a few typos
Updated tests to cover the case where referenced instances have been removed earlier in the run.

/cc @danawillow

@danawillow
Copy link
Contributor

Looks good, congrats on your first contribution!

make testacc TEST=./google TESTARGS='-run=TestAccComputeInstanceGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccComputeInstanceGroup -timeout 120m
=== RUN   TestAccComputeInstanceGroup_basic
--- PASS: TestAccComputeInstanceGroup_basic (117.66s)
=== RUN   TestAccComputeInstanceGroup_update
--- PASS: TestAccComputeInstanceGroup_update (162.80s)
=== RUN   TestAccComputeInstanceGroup_outOfOrderInstances
--- PASS: TestAccComputeInstanceGroup_outOfOrderInstances (113.18s)
=== RUN   TestAccComputeInstanceGroup_network
--- PASS: TestAccComputeInstanceGroup_network (150.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	543.889s

@danawillow danawillow merged commit 6663516 into hashicorp:master Jul 13, 2017
@rosbo rosbo deleted the rosbo_instance_group_issue branch July 13, 2017 17:26
@tomwilkie
Copy link

Thanks!

negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform doesn't notice when named ports have changed in google_compute_instance_group
3 participants