Read named ports changes properly in google_compute_instance_group #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #170
Set the named ports when reading the current state of an instance group.
Removed the call to the read method in the update method before performing the actual update, this overrides the changes to the named ports field with my fix.
In order to handle the case where referenced instances have been removed earlier in the run, instead of doing the pre-read, don't fail if the InstanceGroups#RemoveInstances method returns a 404 (Not Found). If the instances have already been removed, this is the state we want to be in anyway.
Fixed a few typos
Updated tests to cover the case where referenced instances have been removed earlier in the run.
/cc @danawillow