Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds empty background if property is set #3477

Merged
merged 8 commits into from
Sep 22, 2023
Merged

feat: adds empty background if property is set #3477

merged 8 commits into from
Sep 22, 2023

Conversation

FritzHoing
Copy link
Contributor

@FritzHoing FritzHoing commented Aug 28, 2023 •
edited
Loading

Description

Adds a toggle-button to turn of the visibility of the selected layer.

image

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

dnlkoch
dnlkoch previously requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would add an actual layer to the map and the layer would be visible in a layer tree and other related components. Can't we just add a custom element to the layer chooser changing the visible status of each background layer to false?

jansule
jansule previously requested changes Aug 28, 2023
View reviewed changes
src/BackgroundLayerChooser/BackgroundLayerChooser.tsx Outdated Show resolved Hide resolved
@FritzHoing
Copy link
Contributor Author

I have now added a toggle button instead of creating a new layer.

dnlkoch
dnlkoch reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very nice @FritzHoing!

src/BackgroundLayerChooser/BackgroundLayerChooser.tsx Outdated Show resolved Hide resolved
src/BackgroundLayerChooser/BackgroundLayerChooser.tsx Outdated Show resolved Hide resolved
src/BackgroundLayerChooser/BackgroundLayerChooser.tsx Show resolved Hide resolved
@FritzHoing FritzHoing force-pushed the layer-chooser branch 2 times, most recently from b48bf5b to 1b65998 Compare August 29, 2023 12:58
KaiVolland
KaiVolland approved these changes Sep 22, 2023
View reviewed changes
src/BackgroundLayerChooser/BackgroundLayerChooser.tsx Outdated
backgroundLayerFilter?: (layer: OlLayerBase) => boolean;
initialLayer?: OlLayer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some code docs here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@FritzHoing FritzHoing dismissed stale reviews from jansule and dnlkoch September 22, 2023 07:11

outdated

@FritzHoing FritzHoing requested a review from dnlkoch September 22, 2023 09:47
@FritzHoing FritzHoing merged commit c093a2a into main Sep 22, 2023
github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
@semantic-release-bot
chore(release): 23.1.0 [skip ci]
f660f53 
# [23.1.0](v23.0.1...v23.1.0) (2023-09-22)

### Features

* adds empty background if property is set ([#3477](#3477)) ([c093a2a](c093a2a))
@dnlkoch
Copy link
Member

dnlkoch commented Sep 22, 2023

🎉 This PR is included in version 23.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dnlkoch dnlkoch deleted the layer-chooser branch October 24, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiVolland KaiVolland KaiVolland approved these changes

@jansule jansule Awaiting requested review from jansule

@dnlkoch dnlkoch Awaiting requested review from dnlkoch

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FritzHoing @dnlkoch @KaiVolland @jansule