Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getMostSpecificRule in GeoServerInterceptorService #311

Closed
KaiVolland opened this issue Apr 5, 2018 · 2 comments
Closed

Refactor getMostSpecificRule in GeoServerInterceptorService #311

KaiVolland opened this issue Apr 5, 2018 · 2 comments
Labels
bug

Comments

@KaiVolland
Copy link
Member

The getMostSpecificRule method in the GeoServerInterceptorService needs to be refactored as the first rule that matches any of the checks in the condition Predicate will be returned as the most specific, even if possible following rules are more specific.

The condition does not compare rules with each other.
@KaiVolland KaiVolland added the bug label Apr 5, 2018
@marcjansen
Copy link
Member

And please add a test case verifying the correct behaviour.

@ahennr
Copy link
Member

ahennr commented Apr 9, 2018

See #312 and #313

@ahennr ahennr closed this as completed Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcjansen @KaiVolland @ahennr