From 6ebd591f8a469796f6596412d0cc6f7e06359d72 Mon Sep 17 00:00:00 2001 From: sdobbert Date: Wed, 26 Jun 2024 14:07:48 +0200 Subject: [PATCH 1/3] test: add accessibility test --- package-lock.json | 44 +++++++++++++++++++++++++++++ package.json | 2 ++ src/e2e-tests/accessibility.spec.ts | 19 +++++++++++++ 3 files changed, 65 insertions(+) create mode 100644 src/e2e-tests/accessibility.spec.ts diff --git a/package-lock.json b/package-lock.json index ca72fb3e0..1369b80ab 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9,6 +9,7 @@ "version": "8.5.0", "license": "BSD-2-Clause", "dependencies": { + "@axe-core/playwright": "^4.9.1", "@monaco-editor/react": "^4.5.1", "@reduxjs/toolkit": "^2.2.3", "@terrestris/base-util": "^1.0.1", @@ -19,6 +20,7 @@ "@terrestris/shogun-e2e-tests": "^1.0.4", "@terrestris/shogun-util": "7.2.0-ol7.2", "antd": "^4.24.4", + "axe-html-reporter": "^2.2.3", "color": "^4.2.3", "dotenv": "^16.3.1", "geostyler": "^12.0.0", @@ -172,6 +174,17 @@ "react": ">=16.9.0" } }, + "node_modules/@axe-core/playwright": { + "version": "4.9.1", + "resolved": "https://registry.npmjs.org/@axe-core/playwright/-/playwright-4.9.1.tgz", + "integrity": "sha512-8m4WZbZq7/aq7ZY5IG8GqV+ZdvtGn/iJdom+wBg+iv/3BAOBIfNQtIu697a41438DzEEyptXWmC3Xl5Kx/o9/g==", + "dependencies": { + "axe-core": "~4.9.1" + }, + "peerDependencies": { + "playwright-core": ">= 1.0.0" + } + }, "node_modules/@babel/cli": { "version": "7.24.5", "resolved": "https://registry.npmjs.org/@babel/cli/-/cli-7.24.5.tgz", @@ -9163,6 +9176,29 @@ "url": "https://github.com/sponsors/ljharb" } }, + "node_modules/axe-core": { + "version": "4.9.1", + "resolved": "https://registry.npmjs.org/axe-core/-/axe-core-4.9.1.tgz", + "integrity": "sha512-QbUdXJVTpvUTHU7871ppZkdOLBeGUKBQWHkHrvN2V9IQWGMt61zf3B45BtzjxEJzYuj0JBjBZP/hmYS/R9pmAw==", + "engines": { + "node": ">=4" + } + }, + "node_modules/axe-html-reporter": { + "version": "2.2.3", + "resolved": "https://registry.npmjs.org/axe-html-reporter/-/axe-html-reporter-2.2.3.tgz", + "integrity": "sha512-io8aCEt4fJvv43W+33n3zEa8rdplH5Ti2v5fOnth3GBKLhLHarNs7jj46xGfpnGnpaNrz23/tXPHC3HbwTzwwA==", + "dependencies": { + "mustache": "^4.0.1", + "rimraf": "^3.0.2" + }, + "engines": { + "node": ">=8.9.0" + }, + "peerDependencies": { + "axe-core": ">=3" + } + }, "node_modules/babel-jest": { "version": "29.7.0", "resolved": "https://registry.npmjs.org/babel-jest/-/babel-jest-29.7.0.tgz", @@ -18894,6 +18930,14 @@ "multicast-dns": "cli.js" } }, + "node_modules/mustache": { + "version": "4.2.0", + "resolved": "https://registry.npmjs.org/mustache/-/mustache-4.2.0.tgz", + "integrity": "sha512-71ippSywq5Yb7/tVYyGbkBggbU8H3u5Rz56fH60jGFgr8uHwxs+aSKeqmluIVzM0m0kB7xQjKS6qPfd0b2ZoqQ==", + "bin": { + "mustache": "bin/mustache" + } + }, "node_modules/mz": { "version": "2.7.0", "resolved": "https://registry.npmjs.org/mz/-/mz-2.7.0.tgz", diff --git a/package.json b/package.json index a7af5857b..c8c3f709d 100644 --- a/package.json +++ b/package.json @@ -42,6 +42,7 @@ "not IE 11" ], "dependencies": { + "@axe-core/playwright": "^4.9.1", "@monaco-editor/react": "^4.5.1", "@reduxjs/toolkit": "^2.2.3", "@terrestris/base-util": "^1.0.1", @@ -52,6 +53,7 @@ "@terrestris/shogun-e2e-tests": "^1.0.4", "@terrestris/shogun-util": "7.2.0-ol7.2", "antd": "^4.24.4", + "axe-html-reporter": "^2.2.3", "color": "^4.2.3", "dotenv": "^16.3.1", "geostyler": "^12.0.0", diff --git a/src/e2e-tests/accessibility.spec.ts b/src/e2e-tests/accessibility.spec.ts new file mode 100644 index 000000000..21c6483b5 --- /dev/null +++ b/src/e2e-tests/accessibility.spec.ts @@ -0,0 +1,19 @@ + +import { test } from '@playwright/test'; + +import { scan } from '@terrestris/shogun-e2e-tests/dist/accessibility/client'; + +test.use({ + storageState: 'playwright/.auth/admin.json' +}); + +test('accessibility', async ({ + page +}) => { + + await page.goto(`https://${process.env.HOST}/client/?applicationId=${process.env.ID}`); + await page.waitForTimeout(5000); + + await page.waitForLoadState('networkidle'); + await scan(page); +}); From 3484aa4c5eb7a94c24c8623e7a79c220ac7c6432 Mon Sep 17 00:00:00 2001 From: sdobbert Date: Tue, 2 Jul 2024 08:44:09 +0200 Subject: [PATCH 2/3] chore: move axe-core to devDependencies --- package-lock.json | 8 ++++++-- package.json | 4 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index 1369b80ab..24215682c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9,7 +9,6 @@ "version": "8.5.0", "license": "BSD-2-Clause", "dependencies": { - "@axe-core/playwright": "^4.9.1", "@monaco-editor/react": "^4.5.1", "@reduxjs/toolkit": "^2.2.3", "@terrestris/base-util": "^1.0.1", @@ -20,7 +19,6 @@ "@terrestris/shogun-e2e-tests": "^1.0.4", "@terrestris/shogun-util": "7.2.0-ol7.2", "antd": "^4.24.4", - "axe-html-reporter": "^2.2.3", "color": "^4.2.3", "dotenv": "^16.3.1", "geostyler": "^12.0.0", @@ -40,6 +38,7 @@ "shapefile.js": "^1.1.3" }, "devDependencies": { + "@axe-core/playwright": "^4.9.1", "@babel/cli": "^7.19.3", "@babel/core": "^7.20.5", "@babel/preset-env": "^7.20.2", @@ -67,6 +66,7 @@ "@types/node": "^20.4.2", "@typescript-eslint/eslint-plugin": "^6.1.0", "@typescript-eslint/parser": "^6.1.0", + "axe-html-reporter": "^2.2.3", "babel-jest": "^29.3.1", "babel-loader": "^9.1.0", "buffer": "^6.0.3", @@ -178,6 +178,7 @@ "version": "4.9.1", "resolved": "https://registry.npmjs.org/@axe-core/playwright/-/playwright-4.9.1.tgz", "integrity": "sha512-8m4WZbZq7/aq7ZY5IG8GqV+ZdvtGn/iJdom+wBg+iv/3BAOBIfNQtIu697a41438DzEEyptXWmC3Xl5Kx/o9/g==", + "dev": true, "dependencies": { "axe-core": "~4.9.1" }, @@ -9180,6 +9181,7 @@ "version": "4.9.1", "resolved": "https://registry.npmjs.org/axe-core/-/axe-core-4.9.1.tgz", "integrity": "sha512-QbUdXJVTpvUTHU7871ppZkdOLBeGUKBQWHkHrvN2V9IQWGMt61zf3B45BtzjxEJzYuj0JBjBZP/hmYS/R9pmAw==", + "dev": true, "engines": { "node": ">=4" } @@ -9188,6 +9190,7 @@ "version": "2.2.3", "resolved": "https://registry.npmjs.org/axe-html-reporter/-/axe-html-reporter-2.2.3.tgz", "integrity": "sha512-io8aCEt4fJvv43W+33n3zEa8rdplH5Ti2v5fOnth3GBKLhLHarNs7jj46xGfpnGnpaNrz23/tXPHC3HbwTzwwA==", + "dev": true, "dependencies": { "mustache": "^4.0.1", "rimraf": "^3.0.2" @@ -18934,6 +18937,7 @@ "version": "4.2.0", "resolved": "https://registry.npmjs.org/mustache/-/mustache-4.2.0.tgz", "integrity": "sha512-71ippSywq5Yb7/tVYyGbkBggbU8H3u5Rz56fH60jGFgr8uHwxs+aSKeqmluIVzM0m0kB7xQjKS6qPfd0b2ZoqQ==", + "dev": true, "bin": { "mustache": "bin/mustache" } diff --git a/package.json b/package.json index c8c3f709d..002ea9125 100644 --- a/package.json +++ b/package.json @@ -42,7 +42,6 @@ "not IE 11" ], "dependencies": { - "@axe-core/playwright": "^4.9.1", "@monaco-editor/react": "^4.5.1", "@reduxjs/toolkit": "^2.2.3", "@terrestris/base-util": "^1.0.1", @@ -53,7 +52,6 @@ "@terrestris/shogun-e2e-tests": "^1.0.4", "@terrestris/shogun-util": "7.2.0-ol7.2", "antd": "^4.24.4", - "axe-html-reporter": "^2.2.3", "color": "^4.2.3", "dotenv": "^16.3.1", "geostyler": "^12.0.0", @@ -73,6 +71,7 @@ "shapefile.js": "^1.1.3" }, "devDependencies": { + "@axe-core/playwright": "^4.9.1", "@babel/cli": "^7.19.3", "@babel/core": "^7.20.5", "@babel/preset-env": "^7.20.2", @@ -100,6 +99,7 @@ "@types/node": "^20.4.2", "@typescript-eslint/eslint-plugin": "^6.1.0", "@typescript-eslint/parser": "^6.1.0", + "axe-html-reporter": "^2.2.3", "babel-jest": "^29.3.1", "babel-loader": "^9.1.0", "buffer": "^6.0.3", From 39e2bcd2bff018f65f964e8ce96494cd390f4795 Mon Sep 17 00:00:00 2001 From: sdobbert <132580338+sdobbert@users.noreply.github.com> Date: Tue, 2 Jul 2024 08:46:11 +0200 Subject: [PATCH 3/3] Update src/e2e-tests/accessibility.spec.ts Co-authored-by: Lukas Lohoff --- src/e2e-tests/accessibility.spec.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/e2e-tests/accessibility.spec.ts b/src/e2e-tests/accessibility.spec.ts index 21c6483b5..4cc5dde63 100644 --- a/src/e2e-tests/accessibility.spec.ts +++ b/src/e2e-tests/accessibility.spec.ts @@ -1,4 +1,3 @@ - import { test } from '@playwright/test'; import { scan } from '@terrestris/shogun-e2e-tests/dist/accessibility/client';