Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup duplicated methods of KeycloakUtil and SecurityContextUtil #329

Closed
KaiVolland opened this issue May 31, 2021 · 0 comments · Fixed by #330
Closed

Cleanup duplicated methods of KeycloakUtil and SecurityContextUtil #329

KaiVolland opened this issue May 31, 2021 · 0 comments · Fixed by #330
Assignees
@KaiVolland

Comments

@KaiVolland
Copy link
Member

The util classes KeycloakUtil and SecurityContextUtil contain several more or less identical methods.
This needs to be cleaned up.

e.g:

  • KeycloakUtil.getKeycloakUserIdFromAuthentication vs. SecurityContextUtil.getKeycloakUserIdFromAuthentication
  • KeycloakUtil.getUserGroups vs SecurityContextUtil.getKeycloakGroupsForUser
  • …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaiVolland KaiVolland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates to KeycloakUtil KaiVolland/shogun
1 participant
@KaiVolland