Introduces "describeModel" interface. #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buehner
requested changes
Sep 5, 2017
| * | ||
| */ | ||
| @Service("modelDescriptionService") | ||
| public class ModelDescriptionService<E extends PersistentObject> { |
There was a problem hiding this comment.
<E extends PersistentObject> is not necessary if no instances of PersistentObject are managed by this service.
| public class ModelDescriptionService<E extends PersistentObject> { | ||
|
|
||
| public JsonSchema getJsonSchema(Class<?> clazz) throws IOException { | ||
| ObjectMapper mapper = new ObjectMapper(); |
There was a problem hiding this comment.
There is a project-specific ObjectMapper that is available as bean (if archetype has been used) and should be used here:
KaiVolland
force-pushed
the
decribe-model
branch
from
819bba2 to
fb903c9
Compare
KaiVolland
changed the title
marcjansen
approved these changes
Nov 23, 2017
|
|
||
| JsonSchema json = modelDescriptionService.getJsonSchema(foundClass); | ||
|
|
||
| JsonSchema json = modelDescriptionService.getJsonSchema(className); | ||
| return ResultSet.success(json); |
There was a problem hiding this comment.
We might want to return a ResultSet.error() if the json is null. you decide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a describe-model interface which describes any model as a json-schema.
Makes use of https://github.com/FasterXML/jackson-module-jsonSchema
Does currently not support custom serializers.