Intercept OGC requests with basic auth by default #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Much love! LGTM. Please merge. |
chrismayer
approved these changes
Dec 10, 2018
|
|
||
| /** | ||
| * | ||
| */ |
| /** | ||
| * | ||
| */ | ||
| @Value("${geoserver.username}") |
|
|
||
| /** | ||
| * | ||
| */ |
|
|
||
| /** | ||
| * | ||
| */ |
|
|
||
| /** | ||
| * | ||
| */ |
|
|
||
| /** | ||
| * | ||
| */ |
|
|
||
| /** | ||
| * | ||
| */ |
|
|
||
| /** | ||
| * | ||
| */ |
|
|
||
| /** | ||
| * | ||
| */ |
|
|
||
| /** | ||
| * | ||
| */ |
|
Just a general question: Would it be meaningful to introduce a base implementation for OwsInterceptions? Like class WmsRequestInterceptor extends OwsRequestInterception implements WpsRequestInterceptorInterface {}whereas |
|
Thanks for your comments. The whole formatting of these files was a crazy mix. I fixed that. Thanks for the hint @chrismayer Regarding your idea to introduce a new base implementation: Yes. I think this would be possible here, but currently i don't see a real need as this will mainly change the class hierarchy. But feel free to open a PR ;-) I'll merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution for #315 to add basic auth credentials (based on geoserver properties) for each OGC request within the interceptor. In case the geoserver or certain services are not protected, this will not break anything.
The main class is
BasicAuthHeaderRequest.java(extending ourMutableHttpServletRequest), which will actually add the basic auth header. The credentials can be passed in the constructor, which may also be helpful in project solutions with more specific requirements.The new classes in the
de.terrestris.shogun2.util.interceptor.implpackage are default implementations for shogun2 and use the credentials from thegeoserver.userandgeoserver.passwordproperties. They can be seen as a demo on how to use theBasicAuthHeaderRequestclass.The webapp archetype has also been adapted to make use of the new default implementations.