Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't re-render course graph on dark mode toggle #492

Open
terror opened this issue Mar 11, 2024 · 2 comments
Open

Don't re-render course graph on dark mode toggle #492

terror opened this issue Mar 11, 2024 · 2 comments

Comments

@terror
Copy link
Owner

terror commented Mar 11, 2024

=> Is this even possible
@SamZhang02
Copy link
Collaborator

SamZhang02 commented Mar 16, 2024 •
edited
Loading

I don't think that's possible, dark mode impacts some node colors in the course graph
CleanShot 2024-03-15 at 22 06 14@2x
If we don't change the color and take out of useDarkMode() hook in the component, then it won't re-render

@terror
Copy link
Owner Author

terror commented Mar 16, 2024

I don't think that's possible, dark mode impacts some node colors in the course graph

CleanShot 2024-03-15 at 22 06 14@2x

If we don't change the color and take out of useDarkMode() hook in the component, then it won't re-render

Maybe re-render wasn't the right word, it's mainly the startup animation we could probably get rid of

@terror terror moved this to Todo in mcgill.courses Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
mcgill.courses
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@terror @SamZhang02