Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support storing sco::Optimizer::Callbacks in ProblemConstructionInfo class #291

Conversation

Levi-Armstrong
Copy link
Contributor

No description provided.

@Levi-Armstrong Levi-Armstrong force-pushed the feat/AddCallbacksToPCI branch 3 times, most recently from 68ce6ee to c300363 Compare June 29, 2022 13:41
@Levi-Armstrong
Copy link
Contributor Author

@johnwason Any thoughts on why the windows build is finding a cache but seems to still build all of the vcpkgs? This does not happen on the tesseract build.

@johnwason
Copy link
Contributor

@Levi-Armstrong no, I don't see where the issues is. I don't know if it will cache a pull request, maybe that is the issue?

@Levi-Armstrong
Copy link
Contributor Author

@Levi-Armstrong no, I don't see where the issues is. I don't know if it will cache a pull request, maybe that is the issue?

Is that what this line is doing?
if: startsWith(github.ref, 'refs/tags/v') != true

@johnwason
Copy link
Contributor

No, that line prevents caching for release builds. I start my releases with v.

@Levi-Armstrong Levi-Armstrong force-pushed the feat/AddCallbacksToPCI branch 2 times, most recently from 62b0b51 to 2e1b4c9 Compare July 1, 2022 13:21
@Levi-Armstrong Levi-Armstrong merged commit 71fbdd5 into tesseract-robotics:master Jul 1, 2022
@Levi-Armstrong Levi-Armstrong deleted the feat/AddCallbacksToPCI branch July 1, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants