Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test tsp breakingchange] 05 change only one swagger #3530

Closed
wants to merge 4 commits into from

Merge branch 'main' into jacktn/test-tspsup-5

87bb199
Select commit
Loading
Failed to load commit list.
Closed

[test tsp breakingchange] 05 change only one swagger #3530

Merge branch 'main' into jacktn/test-tspsup-5
87bb199
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app-test / Swagger LintDiff failed Oct 17, 2024 in 5m 10s

Swagger LintDiff failed

LintDiff: 66 Errors, 44 Warnings
View Azure DevOps build log for more details.

Details

Compared specs (v2.2.3) new version base version
package-2018-06 package-2018-06(87bb199) package-2018-06(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ OperationsAPIImplementation Operations API must be implemented for 'Microsoft.DataFactory'.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1
❌ TopLevelResourcesListByResourceGroup The top-level resource 'Factory' does not have list by resource group operation, please add it.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6089		 RPC-Get-V1-05


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L274
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L359
❌ GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L379
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L418
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L618
❌ GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L677
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L719
❌ ConsistentPatchProperties The property 'autoUpdate' in the request body either not apppear in the resource model or has the wrong level.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L762
❌ ConsistentPatchProperties The property 'updateDelayOffset' in the request body either not apppear in the resource model or has the wrong level.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L762
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L872
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L903
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1097
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1103
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1110
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1143
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1149
❌ OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'IntegrationRuntimes' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1340
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1426
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1432
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1735
❌ GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1797
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1839
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1940
❌ GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2002
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2044
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2145
❌ GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2207
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2249
❌ ParametersInPost referencePipelineRunId is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2316
❌ ParametersInPost isRecovery is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2316
❌ ParametersInPost startActivityName is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2316
❌ ParametersInPost startFromFailure is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2316
❌ ParametersInPost isRecursive is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2552
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2686
❌ GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2748
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2790
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2882
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2888
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2976
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2982
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2989
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3025
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3032
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3068
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3216
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3472
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3677
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3729
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3933
❌ GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3992
View more details on openapi-pipeline-app-test