-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example from readme results in panic with older docker versions #300
Comments
Hey! Thank you for your report. Can you define old? And can you paste the panic? Thanks |
I have upgraded my Docker right away. It is related to this particular issue with Docker Desktop for Mac, as far as I remember. |
There is ongoing work to refactor the docs: #351 I think we could close this one if that one is merged |
Let's close this issue, as it seems fixed by the Docker for Mac upgrade. Apart from that, in #353 the examples were updated |
from README.md:
if the call to
GenericContainer()
fails, then the error reported but test execution is continued untilip, err := nginxC.Host(ctx)
where it results in panic due to nil pointer dereference.I think there should be
t.Fatalf("cannot create container: %s, check your docker version", err)
instead oft.Error(err)
to reduce possible confusion.
The text was updated successfully, but these errors were encountered: