You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think moving compose files to their own module would simplify the dependency tree for testcontainer-go.
Users of compose will have to deal with the transitive dependencies hack that we currently have at the main module, caused by Compose for Go, removing them from the main.
@baez90 wdyt?
The text was updated successfully, but these errors were encountered:
mdelapenya
changed the title
[Enhancement]: Move compose code to a separate module
[Enhancement]: Move compose code to a separate Go module
Nov 30, 2022
I like the idea! Also I'm sorry that docker-compose refactoring caused so much pain so far but moving it to an extra module makes sense and keeps the dependency tree sleek for the main module, which is a very good thing!
Well, I should have kept an eye on dependencies too, so I share your feeling :)
Because of Docker Compose is depending on a non-released version of Docker:
The signature of the ContainerStop function -which we use in the Container.Stop function- changed, therefore it's not possible to use the right arguments in the main module: it compiles because it uses Docker v20.10.19+incompatible, but the compose module does not compile because it uses v20.10.3-0.20221013203545-33ab36d6b304+incompatible // 22.06 branch).
I truly think it's the right to do, to separate the module, also because of the number of transitive dependencies that we are distributing have way increased. See the differences between 0.15.0 and 0.16.0.
I started a draft PR here #650, let's see where it takes us
Proposal
I think moving compose files to their own module would simplify the dependency tree for testcontainer-go.
Users of compose will have to deal with the transitive dependencies hack that we currently have at the main module, caused by Compose for Go, removing them from the main.
@baez90 wdyt?
The text was updated successfully, but these errors were encountered: