From cd90aa7310142059cb00f66bbc3693aedf5ddcb2 Mon Sep 17 00:00:00 2001 From: Shai Nagar Date: Sat, 9 Mar 2024 13:22:58 +0200 Subject: [PATCH] fix: unclosed socket warning in db containers (#378) This PR fixes #379 --- core/testcontainers/core/generic.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/core/testcontainers/core/generic.py b/core/testcontainers/core/generic.py index 21bf9d7e..a3bff96e 100644 --- a/core/testcontainers/core/generic.py +++ b/core/testcontainers/core/generic.py @@ -36,7 +36,10 @@ def _connect(self) -> None: import sqlalchemy engine = sqlalchemy.create_engine(self.get_connection_url()) - engine.connect() + try: + engine.connect() + finally: + engine.dispose() def get_connection_url(self) -> str: raise NotImplementedError