From 51dfd00668e60cbc2192ef410b51531839128098 Mon Sep 17 00:00:00 2001 From: sha1n Date: Tue, 15 Aug 2023 09:46:18 +0300 Subject: [PATCH] fixed unclosed socket warning in db containers --- core/testcontainers/core/generic.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/core/testcontainers/core/generic.py b/core/testcontainers/core/generic.py index 7faac273..3fcaf085 100644 --- a/core/testcontainers/core/generic.py +++ b/core/testcontainers/core/generic.py @@ -33,7 +33,10 @@ class DbContainer(DockerContainer): def _connect(self) -> None: import sqlalchemy engine = sqlalchemy.create_engine(self.get_connection_url()) - engine.connect() + try: + engine.connect() + finally: + engine.dispose() def get_connection_url(self) -> str: raise NotImplementedError