-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add config for Svelte #973
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
==========================================
+ Coverage 96.23% 96.27% +0.04%
==========================================
Files 44 46 +2
Lines 2419 2472 +53
Branches 1000 1025 +25
==========================================
+ Hits 2328 2380 +52
- Misses 91 92 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nostrorom! Thanks for your contribution, this LGTM.
🎉 This PR is included in version 7.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors please add @nostrorom for code |
I've put up a pull request to add @nostrorom! 🎉 |
'flat/angular': Linter.FlatConfig; | ||
'flat/dom': Linter.FlatConfig; | ||
'flat/marko': Linter.FlatConfig; | ||
'flat/react': Linter.FlatConfig; | ||
'flat/vue': Linter.FlatConfig; | ||
'flat/angular': Linter.Config<Linter.RulesRecord>; | ||
'flat/dom': Linter.Config<Linter.RulesRecord>; | ||
'flat/marko': Linter.Config<Linter.RulesRecord>; | ||
'flat/react': Linter.Config<Linter.RulesRecord>; | ||
'flat/svelte': Linter.Config<Linter.RulesRecord>; | ||
'flat/vue': Linter.Config<Linter.RulesRecord>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that these types should not have been changed - while Linter.FlatConfig
is marked as deprecated in v9, it's the correct type to be using for v8 since Linter.Config
there resolves to the legacy configuration.
For plugins like this which support both v8 and v9, we should be using the explicit Linter.LegacyConfig
and Linter.FlatConfig
types to ensure users of both receive the right types.
I have opened #976 to revert this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed I didn't realise these were necessary for v8 compatibility
Thanks for the fix !
Checks
Changes
svelte
Linter.FlatConfig
type (deprecated)Context
Adds to #80