Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config for Svelte #973

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

nostrorom
Copy link
Contributor

Checks

Changes

  • Adds recommended config for svelte
  • Updates the Linter.FlatConfig type (deprecated)

Context

Adds to #80

@nostrorom nostrorom changed the title Pr/config svelte Add config for svelte Dec 3, 2024
@nostrorom nostrorom changed the title Add config for svelte feat: add config for svelte Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (93a6ab9) to head (26d360e).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #973      +/-   ##
==========================================
+ Coverage   96.23%   96.27%   +0.04%     
==========================================
  Files          44       46       +2     
  Lines        2419     2472      +53     
  Branches     1000     1025      +25     
==========================================
+ Hits         2328     2380      +52     
- Misses         91       92       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Belco90 Belco90 added the enhancement New feature or request label Dec 3, 2024
@Belco90 Belco90 self-requested a review December 3, 2024 20:57
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nostrorom! Thanks for your contribution, this LGTM.

@Belco90 Belco90 changed the title feat: add config for svelte feat: add config for Svelte Dec 4, 2024
@Belco90 Belco90 added this pull request to the merge queue Dec 4, 2024
Merged via the queue into testing-library:main with commit fc118c7 Dec 4, 2024
31 checks passed
Copy link

github-actions bot commented Dec 4, 2024

🎉 This PR is included in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Belco90
Copy link
Member

Belco90 commented Dec 4, 2024

@all-contributors please add @nostrorom for code

Copy link
Contributor

@Belco90

I've put up a pull request to add @nostrorom! 🎉

Comment on lines -14 to +20
'flat/angular': Linter.FlatConfig;
'flat/dom': Linter.FlatConfig;
'flat/marko': Linter.FlatConfig;
'flat/react': Linter.FlatConfig;
'flat/vue': Linter.FlatConfig;
'flat/angular': Linter.Config<Linter.RulesRecord>;
'flat/dom': Linter.Config<Linter.RulesRecord>;
'flat/marko': Linter.Config<Linter.RulesRecord>;
'flat/react': Linter.Config<Linter.RulesRecord>;
'flat/svelte': Linter.Config<Linter.RulesRecord>;
'flat/vue': Linter.Config<Linter.RulesRecord>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that these types should not have been changed - while Linter.FlatConfig is marked as deprecated in v9, it's the correct type to be using for v8 since Linter.Config there resolves to the legacy configuration.

For plugins like this which support both v8 and v9, we should be using the explicit Linter.LegacyConfig and Linter.FlatConfig types to ensure users of both receive the right types.

I have opened #976 to revert this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed I didn't realise these were necessary for v8 compatibility

Thanks for the fix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants