-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix or disable tests for test-main-pushes action. #13
Comments
Actually I think part of the problem is resolved by cunymatthieu/tgenv#43 We should revisit it. |
I've tried fix de Windows installation in the past, but without success in this pull-request. Maybe I can failed miserably in the tests in the Windows 10. 🤣 |
Yeah, the windows installs are evidently a bit more involved than that. I'm not super enthused to go down that rabbit hole hence my comments about having a think about the value/effort of fixing vs just disable the test and not really supporting it for now. On Windows there are still other options including running it in docker or WSL as I do on my work machine and it works fine. My preference would be to disable the tests for windows as there is no point testing something works that we know doesn't work. If/when we properly support windows installs we can reinstate the tests. |
@iokiwi For me we can disable for now the Windows support in the future we can pick up again. Maybe someone Windows lover can come to help. |
Tests for windows failed after merging. We should disable them or get them working.
Tests for windows weren't run on the pull request to add tests. If we get them working, we should also run them on pull requests.
I haven't had a close look at why they failed but I am wondering about the effort/value tradeoff of fixing vs disabling.
Currently our readme has a tests failed badge which isn't a good look so also wonder if we should do something about that in the meantime.
The text was updated successfully, but these errors were encountered: