From f84297d425172db7413b2e9f80d344ea724e11f0 Mon Sep 17 00:00:00 2001 From: Victor Hugo Brito Fernandes Date: Thu, 8 Jun 2023 10:26:18 -0300 Subject: [PATCH] Receive: upgrading logs for failed uploads to error (#6427) * FIX: upgrading log for failed upload to error Signed-off-by: Victor Fernandes * docs: added changelog entry Signed-off-by: Victor Fernandes --------- Signed-off-by: Victor Fernandes --- CHANGELOG.md | 2 +- cmd/thanos/receive.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 48c05c12a6..13da39913f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,7 +22,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re - [#6352](https://github.com/thanos-io/thanos/pull/6352) Store: Expose store gateway query stats in series response hints. ### Fixed - +- [#6427](https://github.com/thanos-io/thanos/pull/6427) Receive: increasing log level for failed uploads to error - [#6172](https://github.com/thanos-io/thanos/pull/6172) query-frontend: return JSON formatted errors for invalid PromQL expression in the split by interval middleware. - [#6171](https://github.com/thanos-io/thanos/pull/6171) Store: fix error handling on limits. - [#6183](https://github.com/thanos-io/thanos/pull/6183) Receiver: fix off by one in multitsdb flush that will result in empty blocks if the head only contains one sample diff --git a/cmd/thanos/receive.go b/cmd/thanos/receive.go index 0a340a77f3..5175ae089f 100644 --- a/cmd/thanos/receive.go +++ b/cmd/thanos/receive.go @@ -707,12 +707,12 @@ func startTSDBAndUpload(g *run.Group, case <-uploadC: // Upload on demand. if err := upload(ctx); err != nil { - level.Warn(logger).Log("msg", "on demand upload failed", "err", err) + level.Error(logger).Log("msg", "on demand upload failed", "err", err) } uploadDone <- struct{}{} case <-tick.C: if err := upload(ctx); err != nil { - level.Warn(logger).Log("msg", "recurring upload failed", "err", err) + level.Error(logger).Log("msg", "recurring upload failed", "err", err) } } }