Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

receive,ruler: Potentially leaking disk from TSDB Mmap-ed chunks. #2677

Closed
bwplotka opened this issue May 28, 2020 · 5 comments
Closed

receive,ruler: Potentially leaking disk from TSDB Mmap-ed chunks. #2677

bwplotka opened this issue May 28, 2020 · 5 comments
Labels
bug

Comments

@bwplotka
Copy link
Member

Introduced on master by: #2658 (0.13 is fine)

Tracking ticket on Prometheus prometheus/prometheus#7305
@bwplotka bwplotka added the bug label May 28, 2020
@bwplotka
Copy link
Member Author

Affected from f7802ed commit.

@codesome
Copy link
Contributor

codesome commented May 28, 2020 •
edited
Loading

Fixed in prometheus/prometheus#7306, I will open a PR for Prometheus upgrade tomorrow. And I think it should go against release branch and even the latest Prometheus upgrade which happened in master should go in 0.13 because the old upgrade does not include fix to the memory leak in isolation which is there in latest upgrade (found it yesterday).

@bwplotka
Copy link
Member Author

Hmmm, ok.

Let's do serparate updates for release and master then.

@bwplotka
Copy link
Member Author

Let's not put too much on release-0.13 to reduce risk

@bwplotka
Copy link
Member Author

bwplotka commented Jun 1, 2020

#2697 for isolation fix on 0.13.0

@bwplotka bwplotka mentioned this issue Jun 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bwplotka @codesome