Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All result timestamps off by 1ms for certain floating-point input timestamps #2971

Closed
juliusv opened this issue Aug 3, 2020 · 2 comments · Fixed by #2976
Closed

All result timestamps off by 1ms for certain floating-point input timestamps #2971

juliusv opened this issue Aug 3, 2020 · 2 comments · Fixed by #2976
Labels
bug component: query good first issue help wanted

Comments

@juliusv
Copy link
Contributor

juliusv commented Aug 3, 2020

This Cortex issue is relevant for Thanos as well: cortexproject/cortex#2932

I'm getting the same timestamp behavior for the latest Thanos release v0.14.0, when passing in range query timestamps (start / stop of e.g. 1595846748.806 being parsed as 1595846748.805).
@bwplotka
Copy link
Member

bwplotka commented Aug 4, 2020

Thanks!

We just need this: prometheus/prometheus#4941

@bwplotka
Copy link
Member

bwplotka commented Aug 4, 2020

Quick fix is easy, help wanted

@johncming johncming mentioned this issue Aug 4, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug component: query good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Query: Better rounding for incoming query timestamps. johncming/thanos
3 participants
@juliusv @GiedriusS @bwplotka