Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugs in example #4639

Closed
metonymic-smokey opened this issue Sep 5, 2021 · 1 comment · Fixed by #4641
Closed

Minor bugs in example #4639

metonymic-smokey opened this issue Sep 5, 2021 · 1 comment · Fixed by #4641

Comments

@metonymic-smokey
Copy link
Contributor

metonymic-smokey commented Sep 5, 2021

Thanos, Prometheus and Golang version used: latest, 2.29, 1.16

What happened:

  1. In examples/interactive/interactive_test.go, the TestReadOnlyThanosSetup , the message in t.Skip should state "comment" instead of "uncomment".
  2. The docs also lack the steps to run the interactive example. Using a go test command may not come easily to newcomers to Go.

What you expected to happen:
Docs in the tutorial section detailing how to run the interactive example.

@metonymic-smokey
Copy link
Contributor Author

metonymic-smokey commented Sep 5, 2021

@yeya24 here is the issue we discussed about.
Could you please assign me?
Thanks!

@metonymic-smokey metonymic-smokey changed the title Minor bugs in documentation and example Minor bugs in example Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant