-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy: pre-calculate hash at leaf nodes #5682
Comments
Can you please elaborate more on where to add the field for hashes? The |
Once we have more details here, I would be inclined to take a stab at solving this one. |
Idea is to calculate this hash by the sender so that it would be less work on the querier (: |
https://github.com/thanos-io/thanos/blob/32a6c4e03a/pkg/store/storepb/types.proto#L23 If I understand correctly, we can add one more nullable hash field to the chunk itself and populate it at stores? |
@GiedriusS can we close this in light of #5703 ? |
Yep 👍 thanks for your work on this! 💪 |
Is your proposal related to a problem?
We could increase the performance by calculating the hash of a chunk at the leaf node instead of the querier: #5296 (comment)
Describe the solution you'd like
Add another field with the hash and use it.
The text was updated successfully, but these errors were encountered: