Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: pre-calculate hash at leaf nodes #5682

Closed
GiedriusS opened this issue Sep 9, 2022 · 6 comments
Closed

proxy: pre-calculate hash at leaf nodes #5682

GiedriusS opened this issue Sep 9, 2022 · 6 comments

Comments

@GiedriusS
Copy link
Member

Is your proposal related to a problem?

We could increase the performance by calculating the hash of a chunk at the leaf node instead of the querier: #5296 (comment)

Describe the solution you'd like

Add another field with the hash and use it.

@yeya24
Copy link
Contributor

yeya24 commented Sep 9, 2022

Add another field with the hash and use it.

Can you please elaborate more on where to add the field for hashes? The Series API?

@pedro-stanaka
Copy link
Contributor

pedro-stanaka commented Sep 14, 2022

Once we have more details here, I would be inclined to take a stab at solving this one.

@GiedriusS
Copy link
Member Author

Idea is to calculate this hash by the sender so that it would be less work on the querier (:

@yeya24
Copy link
Contributor

yeya24 commented Sep 14, 2022

https://github.com/thanos-io/thanos/blob/32a6c4e03a/pkg/store/storepb/types.proto#L23 If I understand correctly, we can add one more nullable hash field to the chunk itself and populate it at stores?

@pedro-stanaka
Copy link
Contributor

pedro-stanaka commented Nov 10, 2022

@GiedriusS can we close this in light of #5703 ?

@GiedriusS
Copy link
Member Author

Yep 👍 thanks for your work on this! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants