Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Frontend: cache sharding query analysis #5715

Closed
yeya24 opened this issue Sep 23, 2022 · 3 comments
Closed

Query Frontend: cache sharding query analysis #5715

yeya24 opened this issue Sep 23, 2022 · 3 comments
Labels
component: query-frontend difficulty: easy state: someone-working-on-it

Comments

@yeya24
Copy link
Contributor

yeya24 commented Sep 23, 2022

Is your proposal related to a problem?

Considering a lot of queries are executed in a regular basis (like alerting and recording rules evaluation), it might be unnecessary to analyze the same query everytime. We could introduce a LRU cache to cache the QueryAnalysis result or error.

Describe the solution you'd like

Use github.com/hashicorp/golang-lru as the LRU cache and add it to the QueryAnalyzer. Probably there are better LRU implementations but the idea should be similar.
@Rahulkumar2002
Copy link
Contributor

Hello Ben, I would like to work on this issue.

@Rahulkumar2002 Rahulkumar2002 mentioned this issue Oct 2, 2022
Merged
@GiedriusS
Copy link
Member

Fixed in #5749. Thx @Rahulkumar2002 💪

@Rahulkumar2002
Copy link
Contributor

Fixed in #5749. Thx @Rahulkumar2002 💪

No problem 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: query-frontend difficulty: easy state: someone-working-on-it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@GiedriusS @yeya24 @matej-g @Rahulkumar2002