Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing in OTLP support configuring service_name #6184

Closed
fatsheep9146 opened this issue Mar 6, 2023 · 1 comment · Fixed by #6185
Closed

tracing in OTLP support configuring service_name #6184

fatsheep9146 opened this issue Mar 6, 2023 · 1 comment · Fixed by #6185

Comments

@fatsheep9146
Copy link
Contributor

Is your proposal related to a problem?

For now, if we enable thanos tracing in OTLP and push the traces into jaeger, the traces will displayed with a default service name OTLPResourceNoServiceName, which is little bit confusing,

image

So I think we should support service_name option in OTLP config, in order to make the traces more clear in jaeger and any other systems to display traces.

image

Describe the solution you'd like

Support service_name option in OTLP config, in order to make the traces more clear in jaeger and any other systems to display traces.

@ahurtaud
Copy link
Contributor

ahurtaud commented Mar 6, 2023

The PR is valid to me, however, if you want to do it before using the next version.
Setting OTEL_SERVICE_NAME environment variable works ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants