Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Security Headers not implemented #6511

Open
marioferh opened this issue Jul 7, 2023 · 4 comments
Open

HTTP Security Headers not implemented #6511

marioferh opened this issue Jul 7, 2023 · 4 comments

Comments

@marioferh
Copy link

marioferh commented Jul 7, 2023

HTTP Security Headers are not implemented

HTTP headers let the client and the server pass additional information with an HTTP request or response. HTTP headers

In thanos there is a flag with http.config but does not include https://thanos.io/tip/operating/https.md/

Solution

Prometheus has similar flag that include http headers: https://prometheus.io/docs/prometheus/latest/configuration/https/

Implement headers.

Example:
        web: {
          httpConfig: {
            headers: {
              xFrameOptions: "DENY",
            },
          },
        },

Additional context

Prometheus http headers PR

@Vanshikav123
Copy link
Contributor

Can i work on this issue?

@marioferh
Copy link
Author

@Vanshikav123 Hi sure, but we need feedback from other members to know if it is needed.

@Vanshikav123
Copy link
Contributor

Hello @yeya24 please confirm that if this is needed or not.

@gavinmathias
Copy link

I'd like to vote for this as well. I'm getting warnings from a Qualys security scanner
https://success.qualys.com/support/s/article/000002924
about these missing HTTP response headers:

X-Content-Type-Options "nosniff"
Strict-Transport-Security "max-age=31536000; includeSubDomains"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants