From 893be126b58d19181c6a671aca8d267da615e99b Mon Sep 17 00:00:00 2001 From: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> Date: Wed, 5 Feb 2020 14:13:04 +0100 Subject: [PATCH 1/2] Register thanos_alert_sender_errors_total metric. https://github.com/thanos-io/thanos/issues/2100 Fixes #2100 Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> --- pkg/alert/alert.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/alert/alert.go b/pkg/alert/alert.go index 7cb11a75bd..418cb5c831 100644 --- a/pkg/alert/alert.go +++ b/pkg/alert/alert.go @@ -313,7 +313,7 @@ func NewSender( }, []string{"alertmanager"}), } if reg != nil { - reg.MustRegister(s.sent, s.dropped, s.latency) + reg.MustRegister(s.sent, s.errs, s.dropped, s.latency) } return s } From b0f30b8e45b4e96d5f7de1a4b792412c71b1e40b Mon Sep 17 00:00:00 2001 From: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> Date: Wed, 5 Feb 2020 14:16:47 +0100 Subject: [PATCH 2/2] Updated CHANGELOG. Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index dee286e74c..2f7a8d9066 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ We use *breaking* word for marking changes that are not backward compatible (rel - [#2033](https://github.com/thanos-io/thanos/pull/2033) minio-go: Fixed Issue #1494 support Web Identity providers for IAM credentials for AWS EKS - [#1985](https://github.com/thanos-io/thanos/pull/1985) store gateway: Fixed case where series entry is larger than 64KB in index. - [#2051](https://github.com/thanos-io/thanos/pull/2051) ruler: Fixed issue where ruler does not expose shipper metrics. +- [#2101](https://github.com/thanos-io/thanos/pull/2101) ruler: Fixed bug where thanos_alert_sender_errors_total was not registered. ### Added