Update golangci-lint and add promlinter #3992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yeya24 <[email protected]>
|
Let me know if a changelog entry is needed or not. |
GiedriusS
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Great work @yeya24! 🎉 I have been waiting for this for a long time. I'm definitely expecting some tutorials or blog posts from you on this (: I gave a cursory glance at your linter. I guess it would be nice to explicitly mention what client_golang & k8s.io/kube-state-metrics versions are supported in the README on https://github.com/yeya24/promlinter. BTW, I think changelog is not needed as this change is not visible to end users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yeya24 [email protected]
Changes
Close #2430.
This pr updates current golangci-lint to master and add promlinter to check metrics naming.
Verification