From 0c2e7f75773e27bbe1c208792339743e286b959a Mon Sep 17 00:00:00 2001 From: hiteshwani29 Date: Thu, 23 Mar 2023 12:00:04 +0530 Subject: [PATCH] Removed EnableExemplarStorage hardcoded value Signed-off-by: hiteshwani29 --- CHANGELOG.md | 1 + cmd/thanos/receive.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dca8190444..b378317828 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re - [#6183](https://github.com/thanos-io/thanos/pull/6183) Receiver: fix off by one in multitsdb flush that will result in empty blocks if the head only contains one sample - [#6197](https://github.com/thanos-io/thanos/pull/6197) Exemplar OTel: Fix exemplar for otel to use traceId instead of spanId and sample only if trace is sampled - [#6207](https://github.com/thanos-io/thanos/pull/6207) Receive: Remove the shipper once a tenant has been pruned. +- [#6216](https://github.com/thanos-io/thanos/pull/6216) Receiver: removed hard-coded value of EnableExemplarStorage flag and set it according to max-exemplar value ### Changed - [#6168](https://github.com/thanos-io/thanos/pull/6168) Receiver: Make ketama hashring fail early when configured with number of nodes lower than the replication factor. diff --git a/cmd/thanos/receive.go b/cmd/thanos/receive.go index 3c3b4da214..10b3f92a12 100644 --- a/cmd/thanos/receive.go +++ b/cmd/thanos/receive.go @@ -85,7 +85,7 @@ func registerReceive(app *extkingpin.App) { NoLockfile: conf.noLockFile, WALCompression: conf.walCompression, MaxExemplars: conf.tsdbMaxExemplars, - EnableExemplarStorage: true, + EnableExemplarStorage: conf.tsdbMaxExemplars > 0, HeadChunksWriteQueueSize: int(conf.tsdbWriteQueueSize), EnableMemorySnapshotOnShutdown: conf.tsdbMemorySnapshotOnShutdown, EnableNativeHistograms: conf.tsdbEnableNativeHistograms,