Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for xkcd module #14

Open
swapagarwal opened this issue Feb 29, 2020 · 5 comments
Open

Add tests for xkcd module #14

swapagarwal opened this issue Feb 29, 2020 · 5 comments
Assignees

Comments

@swapagarwal
Copy link
Member

See how the module is being called in the code and write tests accordingly. Basically see if the random comic object returned follows the expected schema. This would act as an integration test so that if anything changes in the xkcd api and the corresponding module requires updating, the test should fail!

@adityabisoi
Copy link
Member

adityabisoi commented Mar 21, 2020

@swapagarwal @TeAmP0is0N can pytest be used as the testing framework?

@swapagarwal
Copy link
Member Author

Yes.

@adityabisoi adityabisoi removed their assignment Apr 1, 2020
@adityabisoi
Copy link
Member

@TeAmP0is0N Since I am working on other issues as well, I'll work on this as soon as I solve them. I'm unassigning myself for now. Thanks.

@Pihu1998
Copy link

Hi @swapagarwal @TeAmP0is0N . Is this issue up for grabs? Can I be assigned to this issue?

@RohitRathore1
Copy link
Member

@Pihu1998 Please, go ahead. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants